Here is my phpMyAdmin report for May 2019.
In May 2019 I worked on the main repository, sql-parser, docker and the error reporting server. On the side I fixed the time type handling in node-mysql2, '00:00:00' is now returned as a string (#968), and the JWT expiration on octokit/app.js (#33).
First week (18)
I fixed a lot of small issues: the authentication failure page that did not consider SignonCookieParams (#14412, with a new test for setCookieParams), the unexpected behaviour of the Settings reset button (#15037), the multiple errors printed on the Settings page (#15043) and a JSON response shown when returning back to a Settings form with errors (#15240). I also fixed the JavaScript error when editing a JSON data type column (#14301), a TypeError on textContent (#15239), the password copy when copying a user on Percona Server 5.7 (#13726), the privileges of procedures not shown in 4.8.5 (#15238) and the Settings tab not marked as active on the 2FA page (#15157). The error reports themselves were fixed too: the notices when reporting errors are gone (#14992), the current web page url and the real JavaScript file name are reported again, all JS files used to be reported as index.php, and reports too large to be sent are truncated like the PHP side does (#15146). I back-ported the MySQL 8.0 GIS fix (#14383, #12865) and the stored procedure fix (#14614) to the 4.8 branch. On the error reporting server I updated the README, the .gitignore and the configuration setup guide (#182).
- b5245272db - Use ::class for AuthenticationSignon test
- 1c55346cdb - Add a test for setCookieParams
- 47c3f131b4 - Fix #14412 - AuthenticationSignon.php's showFailure function does not consider SignonCookieParams
- 175133d47b - Merge branch 'QA_4_8'
- 20227b058d - Add ChangeLog entry for #15157
- 97ab2953a9 - Fixes #15157 - 'Settings' not marked as active when browsing 2FA settings
- 62ad886718 - Merge branch 'QA_4_8'
- 14ddb9a430 - Add ChangeLog entry for #15240 #15043 and #15037
- 191a81c9b6 - Fix #15037 - Unexpected behavior of reset button
- 8e20d8cf25 - Fix #15043 - Multiple errors printing on Settings page
- 6cc7b0f170 - Fix #15240 - Apply a Settings form with errors shows a JSON response after using return back
- 2ec96f829c - Use [] instead of array()
- b851f9d1fc - Merge branch 'QA_4_8'
- 67c647eb95 - Add ChangeLog entry for #14301
- 821dce6c80 - Fix #14301 - Javascript error when editing a JSON data type column
- c3ed3852bc - Add ChangeLog entry for #15239
- 69e7e59d9b - Fix #15239 - TypeError - Cannot read property 'textContent' of undefined
- 42f690455c - Add ChangeLog entry for #13726
- 3027f0ef49 - Fix #13726 - Can not copy user on Percona Server 5.7 (password copy)
- 1f0e34ad07 - Add ; at the end of SET
old_passwords - 49874c4e28 - Fix #13726 - Can not copy user on Percona Server 5.7
- bb66711c6b - Merge branch 'QA_4_8'
- 8f7a917f11 - Fix #15237 - [UI] Alignment on login form since merge or #15178
- c0d56fa54c - Merge branch 'QA_4_8'
- d6180da08c - Add ChangeLog entry for #15238
- d70d9ecef1 - Fix #15238 - phpMyAdmin 4.8.5 doesn't show privileges of procedures
- c94aec8695 - Fix coding standard warning and removed typehint
- 0bdf3486f3 - Merge branch 'QA_4_8'
- 07389d12aa - Fixed error reporting (current web page url, JS file name sanitization)
- a0d091e1f8 - Add test for sanitizeUrl and improve testGetForm with real data
- fbd89fb882 - Merge branch 'QA_4_8'
- a4714b168d - Add ChangeLog entry for #15059 and #14614
- 5e378298e1 - Add ChangeLog entry for #14383 and #12865
- 89f8b16dcd - Fix #14383 #12865 - Fix GIS functions for mysql 8.0
- e39ae0f989 - Fix #14614 - "# 2014 - Commands out of sync; you can't run this command now" returned when stored procedure does not return any result set
- 8b7db3bd5b - Fix #15059 - Server charset hardcoded in index.php
- 4909352c88 - Fix #14992 - Fixed php notices when reporting errors
- 3989a1ffe2 - Fix #15146 - Error reports can not be sent because too large
- 40cc2dc813 - Fix @var comments to match the phpdoc reference
- 770e28aaf2 - Updated README.md and .gitignore
- 5b19ce658f - #182 updated configuration setup guide in readme
Second week (19)
I added auto-increment support for ROCKSDB and fixed the export of all geometry objects as hex, including in ODS and ODT (#14588). I also fixed the designer export, which now uses POST instead of GET, an undefined index when a dialog is requested, and the SQL queries returning more than -1 affected lines that were not shown as errors (#15251).
- 65b619c5a8 - Merge branch 'QA_4_8'
- 4b2a957123 - Add ChangeLog entry for 47bd88dff
- 47bd88dffa - Add support for auto-increment on ROCKSDB
- 609f9fd871 - Merge branch 'QA_4_8'
- 42d36a75f2 - Use exit; instead of exit(); because exit; is most common in codebase
- 450fdab3d0 - Fix export on designer page (use POST instead of GET)
- 31ab2cb4e8 - Merge branch 'QA_4_8'
- 3500da154f - Fix undefined index dialog
- 0b9aad74e4 - Merge branch 'QA_4_8'
- 3e3a5ce7e2 - Fix failing tests for #14588
- d19bc53626 - Merge branch 'QA_4_8'
- 335ae4fe13 - Fix #14588 - export all geometry objects as hex
- b50a85bb04 - Fix #14588 - export all geometry objects as hex (ODS, ODT)
- 928febd9a3 - Add ChangeLog entry for #14588
- 7f454ac590 - Fix #14588 - export all geometry objects as hex
- bd1a48b3aa - Merge branch 'QA_4_8'
- 7233a887da - Fix #15251 - SQL queries > affected lines > -1 > does not show as error
Third week (20)
I fixed the column options that were ignored for GENERATED/VIRTUAL/STORED columns (#13854) and added support for virtual columns on PerconaDB. I also fixed the key block size formatting, the Filter method on the server variables page (#15174), the "Propose table structure" entry, now added on MariaDB and removed on MySQL 8.0 (#14621), the database tree list when DisableIS is used (#14252, proposed as pull-request #15269) and the missing partitioning on the structure page (#15276).
- 073169f6f3 - Fix key block size (sprintf)
- de4bc0751b - Merge branch 'QA_4_8'
- dceac36518 - Add ChangeLog entry for #13854 and 966902b7a5
- d0cb22a819 - Fix #13854 - Column options are ignored for GENERATED/VIRTUAL/STORED columns
- 966902b7a5 - Add support for virtual columns on PerconaDB
- ae39ea5cbd - Merge branch 'QA_4_8'
- 35fcea7df6 - Fix #14621 - add "Propose table structure" on MariaDB
- e18f697f27 - Add ChangeLog entry for #14621
- 1895900e63 - Fix #14621 - remove "Propose table structure" on MySQL 8.0
- acfdc0f41a - Add ChangeLog entry for #15174
- 8ccb854c5e - Fix #15174 - Improve Filter method in server variables page
- 7b3bfe5c91 - Fix lint error "elseif"
- 24c1481cac - Merge branch 'QA_4_8'
- cf55db06e2 - Add ChangeLog entry for #14252
- 8287ab2ba3 - Fix #14252 - DisableIS and database tree list (refresh db list)
- b7bba700f1 - Add ChangeLog entry for #15276
- 09d20e8c8d - Fix #15276 - Partitioning is missing in Structure page UI
- 6464344618 - Fix #14252 - DisableIS and database tree list (refresh db list)
Fourth week (21)
I fixed the incorrect display of the charset column, the <dfn title= markup was shown as text (#15262), and merged two docker pull-requests, one to remove the .dockerignore file and one to clean unused files.
- c1186dcdba - Merge branch 'QA_4_8'
- 3002944e24 - Add ChangeLog entry for #15262
- be99ab3a1a - Fix #15262 - Incorrect display of charset column : <dfn title=
- 33fc40f4a3 - Merge pull-request #222 (remove .dockerignore)
- 219e173c5e - Merge pull-request #225 (clean unused files)
Fifth week (22)
I fixed the collation changes: an empty input is now checked (#14987), the operations page uses POST instead of REQUEST, and phpMyAdmin no longer tries to change the collation on views when changing all tables (#15283). I also fixed the auto_increment field that was too small (#15287) and the logo link for internal links, with the documentation updated (#15041). On sql-parser I reverted most of a cleanup I did not want in that branch: the new array syntax, the strict mode on PHP files and the bump to PHP 7.1. I also removed the coding-standard package, downgraded phpcs from 3.4 to 2.9.x and fixed the CLI test.
- 62d169258e - Fix #14987 - Add check for empty input to change_collation
- 6f534067cc - Merge branch 'QA_4_8'
- d198598b93 - Fix class name
- 2d4c330b0f - Add ChangeLog entry for #15283
- 6d59e25039 - Use _POST instead of _REQUEST for changing collations in Operations
- fd7f2397d3 - Fix #15283 - phpMyAdmin tries to change collation on Views when changing collation on all tables/fields
- 9d586fc539 - #15041 - Fix logo link for internal links
- 2f2c35c0c2 - Merge branch 'QA_4_8'
- 5d40d309cd - Use spaces instead of a tab for DCO
- 761a1f623b - Fix #15041 - Update documentation for NavigationLogoLink
- e723e34e84 - Add ChangeLog entry for #15287
- 9393db41e7 - Fix #15287 - Fix auto_increment field is too small
- 6bceb49d02 - Change DCO examples to use real world ones
- faebd4d732 - Merge branch 'QA'
- 930444b7bb - Merge #248 'fix-typo-changelog' into QA
- ad831332f9 - Fix CLITest
- 92e97d6234 - revert usage of new array syntax []
- bb6a2b0435 - Downgrade phpcs from 3.4 to to 2.9.x
- 82cfdff6e6 - Edit CHANGELOG.md
- a5b955658e - Revert "Enable strict mode on PHP files"
- b988a6ae83 - remove phpmyadmin/coding-standard and add squizlabs/php_codesniffer
- 930a860bc7 - revert of new array syntax
- 5d5089a259 - Revert array syntax
- 724b2330dc - Partial revert "Bump minimum version to PHP 7.1"